MySQL statements Exponential - howto?

Thursday 11 December 2008 2:54:17 am

Below, this code seems to be very slow, is there anyway to upgrade performance? For example instead of looping through all the attributes getting directly to the one attribute? But I don't know how...

		$objectAttributes =& $object->ContentObjectAttributes();
		foreach($objectAttributes as $objectAttribute)
		{
			//Fetch the object's attribute 'groups' (which is the related objects attribute)
			$name =& $objectAttribute->contentClassAttributeIdentifier();
			//eZDebug::writeNotice("ObjectAttributeName: $name","Workflow smInternalPressReleaseType");

			if($name == "groups")
			{
				$content = $objectAttribute->content();
				foreach( $content['relation_list'] as $relation)
				{
					//eZDebug::writeNotice("Relation ContentClassID: $relation["contentclass_identifier']","Workflow smInternalPressReleaseType");
					//filter the pr_groups from the related list
					if($relation["contentclass_identifier"] == "pr_group")
					{
						$contentobject_id = $relation["contentobject_id"];
						eZDebug::writeNotice("contentobject_id: $contentobject_id","Workflow smInternalPressReleaseType");

						$node_id = $relation["node_id"];
						eZDebug::writeNotice("node_id: $node_id","Workflow smInternalPressReleaseType");						
						/*
						 * Fetch all the PR_MAIL class ID=29 objects from the related node
						 */
						$subtreeFetchParams=array(
							'ClassFilterType' => 'include',
							'ClassFilterArray' => array(29),
							'status' => EZ_CONTENT_OBJECT_STATUS_PUBLISHED);
						
						$childNodes =& eZContentObjectTreeNode::subTree($subtreeFetchParams,$node_id);
						eZDebug::writeNotice("childNodes: $childNodes[0]","Workflow smInternalPressReleaseType");	
												
						foreach( $childNodes as $child )
						{								
							eZDebug::writeNotice("child: $child","Workflow smInternalPressReleaseType");	
						
							//Child is of type eZContentObjectTreeNode			
							if($child->hasContentObject())
							{
								//Fetch the eZContentObject of this eZContentObjectTreeNode
								$childContentObject =& $child->object();

								//Fetch the contentObjectAttributes
								$childAttributes = $childContentObject->ContentObjectAttributes();
								
								eZDebug::writeNotice("childAttributes: $childAttributes[0]","Workflow smInternalPressReleaseType");	
								eZDebug::writeNotice(print_r($childAttributes));
							
								foreach($childAttributes as $childAttribute)
								{
									//Fetch the object's attribute 'groups' (which is the related objects attribute)
									$childAttributename =& $childAttribute->contentClassAttributeIdentifier();									
									eZDebug::writeNotice("childAttributeName: $childAttributename","Workflow smInternalPressReleaseType");		
						
									//only fetch the e-mailaddress
									if($childAttributename=="email")
									{
										eZDebug::writeNotice("childAttributeName: $childAttribute->content()","Workflow smInternalPressReleaseType");			
										$emailsOfReceivers[] = $childAttribute->content();
									}
								}//foreach childattributes
							} //child->hasContentObject
			
						}//foreach childnodes
					}//if relation_list == pr_group
				}//foreach relation_list
			}//if name=="groups"
		}

Thanks as always!

Thursday 11 December 2008 5:42:29 am

Thanks Andre, I've considered that option... but I believe it could make my code fail in the future, so that's why I've done the following changes (change foreach for a array key lookup). It's much faster now!

		//Reject if this object does not have a valid main node
		if(is_null($mainNodeID))
			return EZ_WORKFLOW_TYPE_STATUS_REJECTED;			
		
		$dataMap = $object->dataMap(); 

		if(array_key_exists( 'groups', $dataMap ) )
		{		
			$content = $dataMap['groups']->content();
			foreach( $content['relation_list'] as $relation)
			{
				//eZDebug::writeNotice($relation["contentclass_identifier"], "internal");		
				//filter the pr_groups from the related list
				if($relation["contentclass_identifier"] == "pr_group")
				{
					$contentobject_id = $relation["contentobject_id"];
					$node_id = $relation["node_id"];
					/*
					 * Fetch all the PR_MAIL class ID=29 objects from the related node
					 */
					$subtreeFetchParams=array(
						'ClassFilterType' => 'include',
						'ClassFilterArray' => array(29),
						'status' => EZ_CONTENT_OBJECT_STATUS_PUBLISHED);
					
					$childNodes =& eZContentObjectTreeNode::subTree($subtreeFetchParams,$node_id);				
					foreach( $childNodes as $child )
					{								
						//Child is of type eZContentObjectTreeNode			
						if($child->hasContentObject())
						{
							//Fetch the eZContentObject of this eZContentObjectTreeNode
							$childContentObject =& $child->object();
							$childDataMap = $childContentObject->dataMap(); 

							//eZDebug::writeNotice("childDataMap :".print_r($childDataMap, true), "internal");	
							if(array_key_exists( 'email', $childDataMap ) )
							{
								eZDebug::writeNotice("Un-uniqueified emailOfReceiver: ".$childDataMap['email']->content(),"Workflow smInternalPressReleaseType");									
								$emailsOfReceivers[] = $childDataMap['email']->content();
							}//array_key_exists (email)
						} //child->hasContentObject		
					}//foreach childnodes
				}//if relation_list == pr_group				
			}//foreach relation_list
		}//if array key exists (groups)

Wednesday 17 December 2008 9:10:03 am

This might help:

$node_id = $relation["node_id"];
$subtreeFetchParams = array(
        'ClassFilterType' => 'include',
        'ClassFilterArray' => array(29)
        );

$childNodes =& eZContentObjectTreeNode::subTree($subtreeFetchParams, $node_id);                              
foreach( $childNodes as $child )
{                                                               
    $emailAttribute =& $child->object()->fetchAttributesByIdentifier( array('email') );
    $emailsOfReceivers[] = $emailAttribute->content();
      
}//foreach childnodes

Remove the & after = if your on php5.
Note: If you don't need to check permission, then you can also set 'Limitation' => array() on subtreeFetchParams.

eZ Online Editor 5: http://projects.ez.no/ezoe || eZJSCore (Ajax): http://projects.ez.no/ezjscore || eZ Publish EE http://ez.no/eZPublish/eZ-Publish-Enterprise-Subscription
@: http://twitter.com/andrerom